OK, so how come Wetherspoons (which was one of the first pub chains to bring in a smoking ban, before it was legally required) is always packed to the rafters, even in daytime?
Overpriced drinks/food, and bad service were the downfall of many pubs (both before and after the smoking ban), and the recession has sorted out the wheat from the chaff too.
Round here I can think of dozens of pubs that have closed in the last 10 years, yet hardly any of them were GOOD pubs. They were by and large total dives with bad (or no) food, bad beer, sticky floors, high prices and surly bar staff, as well as customers that may well have stabbed you if you looked at their pint the wrong way. Good riddance.
All of the nice, friendly pubs I know of have stayed open and are doing a roaring trade. The savvy ones have all diversified beyond the usual pint of fizzy brown stuff - even the relatively low end pubs have decent menus and a good choice of guest ales, and Wetherspoons sells more coffee than Starbucks now.
I'm a non-smoker, I love pubs, and I love the ban. Maybe you want to go back to the days of sawdust covered smoky dives full of shady characters coughing up phlegm and barmen with f*ck-off attitudes, but I'll stick to 2010 thanks. The pubs that have closed are the ones we are well rid of.